Skip to content

set unassigned stdin to improve pyinstaller compatibility#1400

Merged
Byron merged 1 commit intogitpython-developers:mainfrom
smokephil:patch-1
Jan 21, 2022
Merged

set unassigned stdin to improve pyinstaller compatibility#1400
Byron merged 1 commit intogitpython-developers:mainfrom
smokephil:patch-1

Conversation

@smokephil
Copy link
Contributor

To create a window application with pyinstaller, all suprocess input and output streams must be assigned and must not be None.
https://stackoverflow.com/a/51706087/7076612

To create a window application with pyinstaller, all suprocess input and output streams must be assigned and must not be None.
https://stackoverflow.com/a/51706087/7076612
@Byron Byron added this to the v3.1.27 - Bugfixes milestone Jan 21, 2022
@Byron Byron merged commit b3f873a into gitpython-developers:main Jan 21, 2022
@Byron
Copy link
Member

Byron commented Jan 21, 2022

Thanks a lot. None probably means that it inherits stdin from its parent environment, which probably rarely is what anybody wants to rely on when using GitPython.

I hope there is no unintended side-effects, and there is only one way to find out :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants